Skip to content

8351277: Remove pipewire from AIX build #3808

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

8351277: Remove pipewire from AIX build #3808

wants to merge 2 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Aug 3, 2025 •
edited by openjdk bot
Loading

I backport this to get later changes clean.
I assume this also helps the AIX port with the pipewire updates.

Progress

  • JDK-8351277 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351277: Remove pipewire from AIX build (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk17u-dev.git pull/3808/head:pull/3808
$ git checkout pull/3808

Update a local copy of the PR:
$ git checkout pull/3808
$ git pull https://git.openjdk.org/jdk17u-dev.git pull/3808/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 3808

View PR using the GUI difftool:
$ git pr show -t 3808

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk17u-dev/pull/3808.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 3, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 3, 2025 •
edited
Loading

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8351277: Remove pipewire from AIX build

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 0c697daf474b580cd447db1cb86b09c85a251175 8351277: Remove pipewire from AIX build Aug 3, 2025
@openjdk
Copy link

openjdk bot commented Aug 3, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 3, 2025
@openjdk
Copy link

openjdk bot commented Aug 3, 2025

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 3, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Aug 3, 2025

Hi @suchismith1993
can you veriy this on AIX?
There are several follow-up changes that also edit the AIX #ifdef part.
I assume this is wanted for AIX anyways, and it makes the follow-up clean, and in itself is clean.

@mlbridge
Copy link

mlbridge bot commented Aug 3, 2025 •
edited
Loading

Webrevs

@suchismith1993
Copy link

Hi @GoeLin
Sorna Sarathi from my team is looking into it. He Will update soon.

@Sorna-Sarathi
Copy link

Hi @GoeLin
I verified in AIX and the build passes without any issues.

@suchismith1993
Copy link

Hi @GoeLin Is there a particular test suite to run for this?

@GoeLin
Copy link
Member Author

GoeLin commented Aug 7, 2025

Hi @Sorna-Sarathi , @suchismith1993
Thanks for verifying.
I think running some of test/jdk/java/awt should be fine.
Best regards, Goetz.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 7, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Aug 11, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Aug 11, 2025

Going to push as commit 2927a67.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 11, 2025
@openjdk openjdk bot closed this Aug 11, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 11, 2025
@openjdk
Copy link

openjdk bot commented Aug 11, 2025

@GoeLin Pushed as commit 2927a67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GoeLin @suchismith1993 @Sorna-Sarathi